Minor flowbit cleanup/v1 #10021
Closed
Minor flowbit cleanup/v1 #10021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DETECT_FLOWBITS_CMD_NOALERT is misleading as it gives an impression that noalert is a flowbit specific command that'll be used and dealt with at some point but as soon as noalert is found in the rule lang, signature flag for noalert is set and control is returned. It never gets added to cmd of the flowbits object.
3 tasks
|
Makes sense to me 👍 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #10021 +/- ##
==========================================
- Coverage 82.47% 82.33% -0.14%
==========================================
Files 970 970
Lines 271372 271369 -3
==========================================
- Hits 223821 223440 -381
- Misses 47551 47929 +378
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Dec 9, 2023
|
Information: QA ran without warnings. Pipeline 16971 |
3 tasks
Merged
|
Merged in #10028, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.